Discussion:
Bug#959191: release-notes: mention configuration file split in logrotate
(too old to reply)
Christian Göttsche
2020-04-30 15:30:02 UTC
Permalink
Package: release-notes

With version 3.14.0 [1] logrotate split the configuration for btmp and
wtmp into separate configuration files.
There are bug reports regarding this issue: #945932, #928516, #922045.

Over at #946779 Julien suggested adding a section (5.3.10 ?).

Maybe the section can be like the following:

The shipped configurations for "/var/log/btmp" and "/var/log/wtmp" have
been split from the main configuration file (/etc/logrotate.conf) into
separate standalone files (/etc/logrotate.d/btmp respectively
/etc/logrotate.d/wtmp).

If you had modified /etc/logrotate.conf in this regard, make sure
to re-adjust the two new files to your needs and drop any references to
(b|w)tmp from the main file, to avoid logrotate skip rotation due to a
duplicate definition.


Best regards,
Christian Göttsche

[1]: https://github.com/logrotate/logrotate/blob/master/ChangeLog.md#3140---2018-03-09
Justin B Rye
2020-04-30 19:10:01 UTC
Permalink
Post by Christian Göttsche
Package: release-notes
With version 3.14.0 [1] logrotate split the configuration for btmp and
wtmp into separate configuration files.
There are bug reports regarding this issue: #945932, #928516, #922045.
To me this seems more like something that should go in the logrotate
NEWS.Debian file, but maybe that's too hard to get into Stable, so
Post by Christian Göttsche
Over at #946779 Julien suggested adding a section (5.3.10 ?).
It would also need a title; maybe something like

5.3.10 Split in configuration for logrotate
Post by Christian Göttsche
The shipped configurations for "/var/log/btmp" and "/var/log/wtmp" have
been split from the main configuration file (/etc/logrotate.conf) into
separate standalone files (/etc/logrotate.d/btmp respectively
^^^^^^^^^^^
Post by Christian Göttsche
/etc/logrotate.d/wtmp).
"Respectively" isn't a conjunction, and there's no need here for
anything more complicated than "and".
Post by Christian Göttsche
If you had modified /etc/logrotate.conf in this regard, make sure
^^^
s/had/have/
Post by Christian Göttsche
to re-adjust the two new files to your needs and drop any references to
(b|w)tmp from the main file, to avoid logrotate skip rotation due to a
^^^^
Post by Christian Göttsche
duplicate definition.
Quick fix: s/skip/skipping/. Probably better:

since duplicate definitions can cause errors.
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
Andrei POPESCU
2020-05-01 07:10:01 UTC
Permalink
Post by Justin B Rye
Post by Christian Göttsche
Package: release-notes
With version 3.14.0 [1] logrotate split the configuration for btmp and
wtmp into separate configuration files.
There are bug reports regarding this issue: #945932, #928516, #922045.
To me this seems more like something that should go in the logrotate
NEWS.Debian file, but maybe that's too hard to get into Stable, so
Indeed.
Post by Justin B Rye
Post by Christian Göttsche
Over at #946779 Julien suggested adding a section (5.3.10 ?).
It would also need a title; maybe something like
5.3.10 Split in configuration for logrotate
Post by Christian Göttsche
The shipped configurations for "/var/log/btmp" and "/var/log/wtmp" have
been split from the main configuration file (/etc/logrotate.conf) into
separate standalone files (/etc/logrotate.d/btmp respectively
^^^^^^^^^^^
Post by Christian Göttsche
/etc/logrotate.d/wtmp).
"Respectively" isn't a conjunction, and there's no need here for
anything more complicated than "and".
Post by Christian Göttsche
If you had modified /etc/logrotate.conf in this regard, make sure
^^^
s/had/have/
Post by Christian Göttsche
to re-adjust the two new files to your needs and drop any references to
(b|w)tmp from the main file, to avoid logrotate skip rotation due to a
^^^^
Post by Christian Göttsche
duplicate definition.
since duplicate definitions can cause errors.
FWIW, LGTM.

Kind regards,
Andrei
--
http://wiki.debian.org/FAQsFromDebianUser
Paul Gevers
2020-05-02 18:30:01 UTC
Permalink
Hi,
Post by Andrei POPESCU
Post by Justin B Rye
It would also need a title; maybe something like
5.3.10 Split in configuration for logrotate
Post by Christian Göttsche
The shipped configurations for "/var/log/btmp" and "/var/log/wtmp" have
been split from the main configuration file (/etc/logrotate.conf) into
separate standalone files (/etc/logrotate.d/btmp respectively
^^^^^^^^^^^
Post by Christian Göttsche
/etc/logrotate.d/wtmp).
"Respectively" isn't a conjunction, and there's no need here for
anything more complicated than "and".
Post by Christian Göttsche
If you had modified /etc/logrotate.conf in this regard, make sure
^^^
s/had/have/
Post by Christian Göttsche
to re-adjust the two new files to your needs and drop any references to
(b|w)tmp from the main file, to avoid logrotate skip rotation due to a
^^^^
Post by Christian Göttsche
duplicate definition.
since duplicate definitions can cause errors.
FWIW, LGTM.
Pushed, thanks. Should be available after the next build.

Paul
Debian Bug Tracking System
2020-05-02 18:40:01 UTC
Permalink
Your message dated Sat, 2 May 2020 20:29:18 +0200
with message-id <41ac25fb-765a-40c8-afcd-***@debian.org>
and subject line Re: Bug#959191: release-notes: mention configuration file split in logrotate
has caused the Debian Bug report #959191,
regarding release-notes: mention configuration file split in logrotate
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ***@bugs.debian.org
immediately.)
--
959191: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959191
Debian Bug Tracking System
Contact ***@bugs.debian.org with problems
Loading...