Processed: Re: Bug#1028002: dash: sid dash globs no longer allow [^...] to negate a class; upcoming breaking change from bullseye

[Debian Bug Tracking System]

clone -1 -2

Bug #1028002 [dash] dash: sid dash globs no longer allow [^...] to negate a class; upcoming breaking change from bullseye
Bug 1028002 cloned as bug 1034345

reassign -2 release-notes

Bug #1034345 [dash] dash: sid dash globs no longer allow [^...] to negate a class; upcoming breaking change from bullseye
Bug reassigned from package 'dash' to 'release-notes'.
No longer marked as found in versions dash/0.5.11+git20210903+057cd650a4ed-9.
Ignoring request to alter fixed versions of bug #1034345 to the same values previously set

[Debian Bug Tracking System]

clone -1 -2

Bug #1028002 [dash] dash: sid dash globs no longer allow [^...] to negate a class; upcoming breaking change from bullseye
Bug 1028002 cloned as bug 1034344

reassign -2 release-notes

Bug #1034344 [dash] dash: sid dash globs no longer allow [^...] to negate a class; upcoming breaking change from bullseye
Bug reassigned from package 'dash' to 'release-notes'.
No longer marked as found in versions dash/0.5.11+git20210903+057cd650a4ed-9.
Ignoring request to alter fixed versions of bug #1034344 to the same values previously set

[Maxim Nikulin]

If the current behaviour
would be part of bookworm, a NEWS entry would be great.

And a release note would be worth it too I guess.

Shellcheck static analyzer detects the issue with [^c] for pattern
matching. I think, it may be recommended for installation
https://packages.debian.org/bookworm/shellcheck or as an online tool
https://www.shellcheck.net/

The warning concerning globs recommends to visit the following page:

https://www.shellcheck.net/wiki/SC3026
SC3026 In POSIX sh, ^ in place of ! in glob bracket expressions is
undefined.

[Richard Lewis]

Please for the love of god add this to the NEWS.
I /guarantee/ people are using '[^0-9]' to mean "not 0-9",
and similar constructs, even if they are well-versed in the shell language.

I’m actually considering reverting that patch, as it seems a bit too late in the release cycle to introduce such a breaking change.

Hi - what is the status of these bugs about globbing in dash: is
there a change in dash and a need to add to release-notes or not?

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028002 against dash
asking for NEWS is still open,
https://salsa.debian.org/debian/dash/-/blob/debian/unstable/debian/dash.NEWS
is not updated since 2009
And the message above says the change might be reverted

So should https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034344
against asking to document in release-notes be closed?

[Debian Bug Tracking System]

tags -1 pending patch

Bug #1034344 [release-notes] dash: sid dash globs no longer allow [^...] to negate a class; upcoming breaking change from bullseye
Bug #1034345 [release-notes] dash: sid dash globs no longer allow [^...] to negate a class; upcoming breaking change from bullseye
Added tag(s) patch and pending.
Added tag(s) pending and patch.

[Paul Gevers]

Control: tags -1 pending patch

Hi,

If the current behaviour
would be part of bookworm, a NEWS entry would be great.

And a release note would be worth it too I guess.

Our (crafted with Andrej) proposal is here:
https://salsa.debian.org/ddp-team/release-notes/-/merge_requests/181

Paul

[Paul Gevers]

Hi,

... A bracket expression
    starting with an unquoted <circumflex> character produces unspecified
    results.

Right. Maybe better to say it now matches the other implementation (dash
has two implementations and they were behaving differently).

Paul

[Paul Gevers]

Hi,

I am unaware of another dash implementation. Do you mean ash from which
dash was forked?

No, I understood from Andrej that dash *internally* has two ways to do
the matching. One embedded implementation, and one using system library
calls. Which one is used depends on the configure options during the
build. Both code paths are now made consistent (with the way dash
maintainers always ment it to be).

Paul

[Debian Bug Tracking System]

Your message dated Mon, 29 May 2023 10:55:42 +0200
with message-id <9ff275c6-bab4-f36b-d6b3-***@debian.org>
and subject line Re: Bug#1028002: dash: sid dash globs no longer allow [^...] to negate a class; upcoming breaking change from bullseye
has caused the Debian Bug report #1034344,
regarding dash: sid dash globs no longer allow [^...] to negate a class; upcoming breaking change from bullseye
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ***@bugs.debian.org
immediately.)

[Debian Bug Tracking System]

Your message dated Mon, 29 May 2023 10:55:42 +0200
with message-id <9ff275c6-bab4-f36b-d6b3-***@debian.org>
and subject line Re: Bug#1028002: dash: sid dash globs no longer allow [^...] to negate a class; upcoming breaking change from bullseye
has caused the Debian Bug report #1034344,
regarding dash: sid dash globs no longer allow [^...] to negate a class; upcoming breaking change from bullseye
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ***@bugs.debian.org
immediately.)